hauke/Magallanes
1
0
Fork 0
mirror of https://github.com/hauke68/Magallanes.git synced 2025-10-30 23:10:16 +01:00
Code Issues Releases Wiki Activity

SensioLabs Insight fixes

Browse Source
This commit is contained in:
Andrés Montañez 2015-04-12 16:15:46 -03:00
parent a0f4920333
commit ce60a706ac
2 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Mage/Command/Factory.php
View File

@ -42,17 +42,14 @@ class Factory
// try a custom command // try a custom command
$className = 'Command\\' . $commandName; $className = 'Command\\' . $commandName;
// TODO use a custom exception
if (!class_exists($className)) { if (!class_exists($className)) {
throw new Exception('Command "' . $commandName . '" not found.'); throw new Exception('Command "' . $commandName . '" not found.');
} }
} }
/** @var AbstractCommand $instance */ /** @var AbstractCommand $instance */
// TODO dependencies like $config should be injected into constructor
$instance = new $className; $instance = new $className;
if (! $instance instanceof AbstractCommand) { if (! $instance instanceof AbstractCommand) {
// TODO use a custom exception
throw new Exception('The command ' . $commandName . ' must be an instance of Mage\Command\AbstractCommand.'); throw new Exception('The command ' . $commandName . ' must be an instance of Mage\Command\AbstractCommand.');
} }

2
Mage/Task/BuiltIn/Deployment/Strategy/GitRebaseTask.php
View File

@ -36,7 +36,7 @@ class GitRebaseTask extends BaseStrategyTaskAbstract implements IsReleaseAware
{ {
$this->checkOverrideRelease(); $this->checkOverrideRelease();
if ($this->getConfig()->release('enabled', false) == true) { if ($this->getConfig()->release('enabled', false) === true) {
$releasesDirectory = $this->getConfig()->release('directory', 'releases'); $releasesDirectory = $this->getConfig()->release('directory', 'releases');
$deployToDirectory = rtrim($this->getConfig()->deployment('to'), '/') $deployToDirectory = rtrim($this->getConfig()->deployment('to'), '/')