[Discovery One] Add Cache Pool Task for Symfony, remove Assetic task

CHANGELOG.md

@@ -1,37 +1,9 @@
-CHANGELOG for 3.X
+CHANGELOG for 4.X
 =================
 
-* 3.4.0 (2018-03-29)
+* 4.0.0 (2018-04-02)
- * [Issue#380] Throw exception if log_dir is defined but directory doesn't exists
+ * v4 series release
- * [BUGFIX] [Issue#405] Malformed ssh command when defining host:port notation
+ * Refactored for Symfony 4 and PHP 7.1
- * [Issue#415] Remove timeout on Deploy with Tar or Rsync tasks
+ * Symfony Pool Clear task added
- 
+ * Symfony Pool Prune task added
-
+ * Symfony Assetic task removed
-* 3.3.0 (2017-07-22)
- * [PR#386] Allow to define timeout (default 120s) for symfony/assetic-dump task.
- * [PR#392] Allow to define Host Port in Host configuration.
- * Allow to specify the binary path of tar on for create and extract
-
-* 3.2.0 (2017-04-14)
- * Allow to pre-register Custom Tasks
- * [PR#365] New option "from" to define deployment start point
- * Allow to define excludes in the global scope.
- * Improve code quality, remove duplications on Symfony Tasks.
- * Improve code quality, remove duplications on Composer Tasks.
- * [PR#364] Allow to define custom timeout to Composer:Install
-
-* 3.1.0 (2017-02-25)
- * Add new Exec task to execute arbitrary shell commands
- * Add new Composer task, to update phar (composer/self-update)
- * [#344] Allow to flag Filesystem tasks
- * [PR#346] Add new File System task, to change file's modes (fs/chmod)
- * [BUGFIX] [PR#342] Ignore empty exclude lines
- * [PR#330] Allow Composer task options to be overwritten at environment level
- * [PR#330] Add new method Runtime::getMergedOption to merge ConfigOption and EnvOption
- * [Documentation] [PR#333] Improve example config file
-
-* 3.0.1 (2017-01-10)
- * [BUGFIX] [#350] [#353] Fix escape issue when commands are sent through SSH
-
-* 3.0.0 (2017-01-31)
- * v3 series release

src/Task/BuiltIn/Symfony/CachePoolClearTask.php

@@ -10,45 +10,44 @@
 
 namespace Mage\Task\BuiltIn\Symfony;
 
+use Mage\Task\Exception\ErrorException;
 use Symfony\Component\Process\Process;
-use Mage\Task\AbstractTask;
 
 /**
- * Symfony Task - Dump Assetics
+ * Symfony Task - Cache Pool Clear
  *
  * @author Andrés Montañez <andresmontanez@gmail.com>
  */
-class AsseticDumpTask extends AbstractTask
+class CachePoolClearTask extends AbstractSymfonyTask
 {
     public function getName()
     {
-        return 'symfony/assetic-dump';
+        return 'symfony/cache-pool-clear';
     }
 
     public function getDescription()
     {
-        return '[Symfony] Assetic Dump';
+        return '[Symfony] Cache Pool Clear';
     }
 
     public function execute()
     {
         $options = $this->getOptions();
-        $command = sprintf('%s assetic:dump --env=%s %s', $options['console'], $options['env'], $options['flags']);
+
+        if (!$options['pools']) {
+            throw new ErrorException('Parameter "pools" is not defined');
+        }
+
+        $command = $options['console'] . ' cache:pool:clear --env=' . $options['env'] . ' ' . $options['flags'] . ' ' . $options['pools'];
 
         /** @var Process $process */
-        $process = $this->runtime->runCommand(trim($command), $options['timeout']);
+        $process = $this->runtime->runCommand(trim($command));
 
         return $process->isSuccessful();
     }
 
-    protected function getOptions()
+    protected function getSymfonyOptions()
     {
-        $options = array_merge(
+        return ['pools' => null];
-            ['console' => 'bin/console', 'env' => 'dev', 'flags' => '', 'timeout' => 120],
-            $this->runtime->getMergedOption('symfony'),
-            $this->options
-        );
-
-        return $options;
     }
 }

src/Task/BuiltIn/Symfony/CachePoolPruneTask.php

@@ -0,0 +1,42 @@
+<?php
+/*
+ * This file is part of the Magallanes package.
+ *
+ * (c) Andrés Montañez <andres@andresmontanez.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Mage\Task\BuiltIn\Symfony;
+
+use Symfony\Component\Process\Process;
+
+/**
+ * Symfony Task - Cache Pool Prune
+ *
+ * @author Andrés Montañez <andresmontanez@gmail.com>
+ */
+class CachePoolPruneTask extends AbstractSymfonyTask
+{
+    public function getName()
+    {
+        return 'symfony/cache-pool-prune';
+    }
+
+    public function getDescription()
+    {
+        return '[Symfony] Cache Pool Prune';
+    }
+
+    public function execute()
+    {
+        $options = $this->getOptions();
+        $command = $options['console'] . ' cache:pool:prune --env=' . $options['env'] . ' ' . $options['flags'];
+
+        /** @var Process $process */
+        $process = $this->runtime->runCommand(trim($command));
+
+        return $process->isSuccessful();
+    }
+}

tests/Command/BuiltIn/DeployCommandMiscTasksTest.php

@@ -35,8 +35,8 @@ class DeployCommandMiscTasksTest extends TestCase
             0 => 'rsync -e "ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no" -avz --exclude=.git --exclude=./var/cache/* --exclude=./var/log/* --exclude=./web/app_dev.php ./ tester@testhost:/var/www/test',
             1 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test && bin/console cache:warmup --env=testenv"',
             2 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test && bin/console assets:install web --env=testenv --symlink --relative"',
-            3 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test && bin/console assetic:dump --env=testenv"',
+            3 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test && bin/console cache:pool:prune --env=testenv"',
-            4 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test && bin/console assetic:dump --env=prod"',
+            4 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test && bin/console cache:pool:prune --env=prod"',
         );
 
         // Check total of Executed Commands

tests/Command/BuiltIn/DeployCommandMiscTest.php

@@ -78,7 +78,7 @@ class DeployCommandMiscTest extends TestCase
             6 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test && sudo bin/console cache:clear --env=dev"',
             7 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test && sudo bin/console cache:warmup --env=dev"',
             8 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test && sudo bin/console assets:install web --env=dev --symlink --relative"',
-            9 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test && sudo bin/console assetic:dump --env=dev"',
+            9 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test && sudo bin/console cache:pool:prune --env=dev"',
             10 => 'git checkout master',
         );
 
@@ -115,7 +115,7 @@ class DeployCommandMiscTest extends TestCase
             5 => 'rsync -e "ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no" -avz --exclude=.git --exclude=./var/cache/* --exclude=./var/log/* --exclude=./web/app_dev.php ./ tester@testhost:/var/www/test',
             6 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test && bin/console cache:warmup --env=dev"',
             7 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test && bin/console assets:install web --env=dev --symlink --relative"',
-            8 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test && bin/console assetic:dump --env=dev"',
+            8 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test && bin/console cache:pool:prune --env=dev"',
             9 => 'git checkout master',
         );
 
@@ -259,7 +259,7 @@ class DeployCommandMiscTest extends TestCase
             4 => 'rsync -e "ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no" -avz --exclude=.git --exclude=./var/cache/* --exclude=./var/log/* --exclude=./web/app_dev.php ./ tester@testhost:/var/www/test',
             5 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test && bin/console cache:warmup --env=dev"',
             6 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test && bin/console assets:install web --env=dev --symlink --relative"',
-            7 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test && bin/console assetic:dump --env=dev"',
+            7 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test && bin/console cache:pool:prune --env=dev"',
             8 => 'git branch | grep "*"',
         );
 

tests/Command/BuiltIn/DeployCommandWithReleasesTest.php

@@ -46,7 +46,7 @@ class DeployCommandWithReleasesTest extends TestCase
             9 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "rm /var/www/test/releases/1234567890/mageXYZ"',
             10 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test/releases/1234567890 && bin/console cache:warmup --env=dev"',
             11 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test/releases/1234567890 && bin/console assets:install web --env=dev --symlink --relative"',
-            12 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test/releases/1234567890 && bin/console assetic:dump --env=dev"',
+            12 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test/releases/1234567890 && bin/console cache:pool:prune --env=dev"',
             13 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test && ln -snf releases/1234567890 current"',
             14 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "ls -1 /var/www/test/releases"',
             15 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "rm -rf /var/www/test/releases/20170101015110"',
@@ -96,7 +96,7 @@ class DeployCommandWithReleasesTest extends TestCase
             9 => 'ssh -p 202 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "rm /var/www/test/releases/1234567890/mageXYZ"',
             10 => 'ssh -p 202 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test/releases/1234567890 && bin/console cache:warmup --env=prod"',
             11 => 'ssh -p 202 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test/releases/1234567890 && bin/console assets:install web --env=prod --symlink --relative"',
-            12 => 'ssh -p 202 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test/releases/1234567890 && bin/console assetic:dump --env=prod"',
+            12 => 'ssh -p 202 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test/releases/1234567890 && bin/console cache:pool:prune --env=prod"',
             13 => 'ssh -p 202 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test && ln -snf releases/1234567890 current"',
             14 => 'ssh -p 202 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "ls -1 /var/www/test/releases"',
             15 => 'ssh -p 202 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "rm -rf /var/www/test/releases/20170101015110"',
@@ -146,7 +146,7 @@ class DeployCommandWithReleasesTest extends TestCase
             9 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "rm /var/www/test/releases/1234567890/mageXYZ"',
             10 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test/releases/1234567890 && bin/console cache:warmup --env=dev"',
             11 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test/releases/1234567890 && bin/console assets:install web --env=dev --symlink --relative"',
-            12 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test/releases/1234567890 && bin/console assetic:dump --env=dev"',
+            12 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test/releases/1234567890 && bin/console cache:pool:prune --env=dev"',
             13 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test && ln -snf releases/1234567890 current"',
             14 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "ls -1 /var/www/test/releases"',
             15 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "rm -rf /var/www/test/releases/20170101015110"',
@@ -356,7 +356,7 @@ class DeployCommandWithReleasesTest extends TestCase
             9 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "rm /var/www/test/releases/1234567890/mageXYZ"',
             10 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test/releases/1234567890 && bin/console cache:warmup --env=dev"',
             11 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test/releases/1234567890 && bin/console assets:install web --env=dev --symlink --relative"',
-            12 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test/releases/1234567890 && bin/console assetic:dump --env=dev"',
+            12 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test/releases/1234567890 && bin/console cache:pool:prune --env=dev"',
             13 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test && ln -snf releases/1234567890 current"',
             14 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "ls -1 /var/www/test/releases"',
             15 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "rm -rf /var/www/test/releases/20170101015110"',
@@ -409,7 +409,7 @@ class DeployCommandWithReleasesTest extends TestCase
             9 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "rm /var/www/test/releases/1234567890/mageXYZ"',
             10 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test/releases/1234567890 && bin/console cache:warmup --env=dev"',
             11 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test/releases/1234567890 && bin/console assets:install web --env=dev --symlink --relative"',
-            12 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test/releases/1234567890 && bin/console assetic:dump --env=dev"',
+            12 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test/releases/1234567890 && bin/console cache:pool:prune --env=dev"',
             13 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test && ln -snf releases/1234567890 current"',
             14 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "ls -1 /var/www/test/releases"',
         );

tests/Command/BuiltIn/DeployCommandWithoutReleasesTest.php

@@ -40,7 +40,7 @@ class DeployCommandWithoutReleasesTest extends TestCase
             5 => 'rsync -e "ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no" -avz --exclude=.git --exclude=./var/cache/* --exclude=./var/log/* --exclude=./web/app_dev.php ./ tester@testhost:/var/www/test',
             6 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test && bin/console cache:warmup --env=dev"',
             7 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test && bin/console assets:install web --env=dev --symlink --relative"',
-            8 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test && bin/console assetic:dump --env=dev"',
+            8 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test && bin/console cache:pool:prune --env=dev"',
             9 => 'git checkout master',
         );
 
@@ -77,7 +77,7 @@ class DeployCommandWithoutReleasesTest extends TestCase
             5 => 'rsync -e "ssh -p 202 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no" -avz --exclude=.git --exclude=./var/cache/* --exclude=./var/log/* --exclude=./web/app_dev.php ./ tester@testhost:/var/www/test',
             6 => 'ssh -p 202 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test && bin/console cache:warmup --env=dev"',
             7 => 'ssh -p 202 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test && bin/console assets:install web --env=dev --symlink --relative"',
-            8 => 'ssh -p 202 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test && bin/console assetic:dump --env=dev"',
+            8 => 'ssh -p 202 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test && bin/console cache:pool:prune --env=dev"',
             9 => 'git checkout master',
         );
 
@@ -114,7 +114,7 @@ class DeployCommandWithoutReleasesTest extends TestCase
             5 => 'rsync -e "ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no" -avz --exclude=.git --exclude=./var/cache/* --exclude=./var/log/* --exclude=./web/app_dev.php ./dist tester@testhost:/var/www/test',
             6 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test && bin/console cache:warmup --env=dev"',
             7 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test && bin/console assets:install web --env=dev --symlink --relative"',
-            8 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test && bin/console assetic:dump --env=dev"',
+            8 => 'ssh -p 22 -q -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no tester@testhost "cd /var/www/test && bin/console cache:pool:prune --env=dev"',
             9 => 'git checkout master',
         );
 

tests/Resources/basic.yml

@@ -21,7 +21,7 @@ magephp:
             on-deploy:
                 - symfony/cache-warmup: { env: 'dev' }
                 - symfony/assets-install: { env: 'dev' }
-                - symfony/assetic-dump: { env: 'dev' }
+                - symfony/cache-pool-prune: { env: 'dev' }
             on-release:
             post-release:
             post-deploy:

tests/Resources/invalid-log.yml

@@ -21,7 +21,7 @@ magephp:
             on-deploy:
                 - symfony/cache-warmup: { env: 'dev' }
                 - symfony/assets-install: { env: 'dev' }
-                - symfony/assetic-dump: { env: 'dev' }
+                - symfony/cache-pool-prune: { env: 'dev' }
             on-release:
             post-release:
             post-deploy:

tests/Resources/no-hosts.yml

@@ -17,7 +17,7 @@ magephp:
             on-deploy:
                 - symfony/cache-warmup: { env: 'dev' }
                 - symfony/assets-install: { env: 'dev' }
-                - symfony/assetic-dump: { env: 'dev' }
+                - symfony/cache-pool-prune: { env: 'dev' }
             on-release:
             post-release:
             post-deploy:

tests/Resources/symfony-envconf.yml

@@ -14,5 +14,5 @@ magephp:
             on-deploy:
                 - symfony/cache-warmup
                 - symfony/assets-install
-                - symfony/assetic-dump
+                - symfony/cache-pool-prune
-                - symfony/assetic-dump: { env: 'prod' }
+                - symfony/cache-pool-prune: { env: 'prod' }

tests/Resources/testhost-skipping.yml

@@ -18,7 +18,7 @@ magephp:
             on-deploy:
                 - symfony/cache-warmup: { env: 'dev' }
                 - symfony/assets-install: { env: 'dev' }
-                - symfony/assetic-dump: { env: 'dev' }
+                - symfony/cache-pool-prune: { env: 'dev' }
             on-release:
             post-release:
             post-deploy:

tests/Resources/testhost-sudo.yml

@@ -20,7 +20,7 @@ magephp:
                 - symfony/cache-clear: { env: 'dev' }
                 - symfony/cache-warmup: { env: 'dev' }
                 - symfony/assets-install: { env: 'dev' }
-                - symfony/assetic-dump: { env: 'dev' }
+                - symfony/cache-pool-prune: { env: 'dev' }
             on-release:
             post-release:
             post-deploy:

tests/Resources/testhost-with-from.yml

@@ -22,7 +22,7 @@ magephp:
             on-deploy:
                 - symfony/cache-warmup: { env: 'dev' }
                 - symfony/assets-install: { env: 'dev' }
-                - symfony/assetic-dump: { env: 'dev' }
+                - symfony/cache-pool-prune: { env: 'dev' }
             on-release:
             post-release:
             post-deploy:

tests/Resources/testhost-with-port.yml

@@ -21,7 +21,7 @@ magephp:
             on-deploy:
                 - symfony/cache-warmup: { env: 'prod' }
                 - symfony/assets-install: { env: 'prod' }
-                - symfony/assetic-dump: { env: 'prod' }
+                - symfony/cache-pool-prune: { env: 'prod' }
             on-release:
             post-release:
             post-deploy:

tests/Resources/testhost-without-releases-with-from.yml

@@ -19,7 +19,7 @@ magephp:
             on-deploy:
                 - symfony/cache-warmup: { env: 'dev' }
                 - symfony/assets-install: { env: 'dev' }
-                - symfony/assetic-dump: { env: 'dev' }
+                - symfony/cache-pool-prune: { env: 'dev' }
             on-release:
             post-release:
             post-deploy:

tests/Resources/testhost-without-releases-with-port.yml

@@ -18,7 +18,7 @@ magephp:
             on-deploy:
                 - symfony/cache-warmup: { env: 'dev' }
                 - symfony/assets-install: { env: 'dev' }
-                - symfony/assetic-dump: { env: 'dev' }
+                - symfony/cache-pool-prune: { env: 'dev' }
             on-release:
             post-release:
             post-deploy:

tests/Resources/testhost-without-releases.yml

@@ -18,7 +18,7 @@ magephp:
             on-deploy:
                 - symfony/cache-warmup: { env: 'dev' }
                 - symfony/assets-install: { env: 'dev' }
-                - symfony/assetic-dump: { env: 'dev' }
+                - symfony/cache-pool-prune: { env: 'dev' }
             on-release:
             post-release:
             post-deploy:

tests/Resources/testhost.yml

@@ -21,7 +21,7 @@ magephp:
             on-deploy:
                 - symfony/cache-warmup: { env: 'dev' }
                 - symfony/assets-install: { env: 'dev' }
-                - symfony/assetic-dump: { env: 'dev' }
+                - symfony/cache-pool-prune: { env: 'dev' }
             on-release:
             post-release:
             post-deploy:

tests/Task/BuiltIn/Symfony/AsseticDumpTaskTest.php

@@ -1,71 +0,0 @@
-<?php
-
-namespace Mage\tests\Task\BuiltIn\Symfony;
-
-
-use Mage\Task\BuiltIn\Symfony\AsseticDumpTask;
-use Mage\Tests\Runtime\RuntimeMockup;
-use PHPUnit\Framework\TestCase;
-
-class AsseticDumpTaskTest extends TestCase
-{
-    /**
-     * @var RuntimeMockup
-     */
-    private $runtime;
-
-    public function setUp()
-    {
-        $this->runtime = new RuntimeMockup();
-        $this->runtime->setConfiguration(['environments' => ['test' => []]]);
-        $this->runtime->setEnvironment('test');
-    }
-
-    public function testAsseticDumpTask()
-    {
-        $task = new AsseticDumpTask();
-        $task->setOptions(['env' => 'test']);
-        $task->setRuntime($this->runtime);
-        $this->assertEquals('[Symfony] Assetic Dump', $task->getDescription());
-        $task->execute();
-
-        $testCase = [
-            'bin/console assetic:dump --env=test' => 120,
-        ];
-
-        $this->assertRanCommands($testCase);
-    }
-
-    public function testAsseticDumpTaskWithTimeoutOption()
-    {
-        $task = new AsseticDumpTask();
-        $task->setOptions(['env' => 'test', 'timeout' => 300]);
-        $task->setRuntime($this->runtime);
-        $task->execute();
-
-
-        $testCase = [
-            'bin/console assetic:dump --env=test' => 300,
-        ];
-
-        $this->assertRanCommands($testCase);
-    }
-
-    /**
-     * @param $testCase
-     */
-    private function assertRanCommands($testCase)
-    {
-        $ranCommands = $this->runtime->getRanCommands();
-
-        // Check total of Executed Commands
-        $this->assertEquals(count($testCase), count($ranCommands));
-
-        // Check Generated Commands
-        $index = 0;
-        foreach ($testCase as $command => $timeout) {
-            $this->assertEquals($command, $ranCommands[$index++]);
-            $this->assertEquals($timeout, $this->runtime->getRanCommandTimeoutFor($command));
-        }
-    }
-}